This repository was archived by the owner on Sep 26, 2025. It is now read-only.
comfyui-refiners fix requirements.txt #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laurent2916
changed the title
deltheil
approved these changes
Sep 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well it looks like #423 doesn't work:
I think this is because they basically do
cat requirements.txt | xargs -i pip install {}and because
-e file:.is obviously an incorrect argument (it should be split in two).Anyway, let's hardcode the actual deps into the requirements.txt and pray that they will also support using the deps directly inside the pyproject.toml in the future.